You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The Navigation block was updated in WordPress/gutenberg#36169 to use the new layout controls, such as Query loop, Row, Buttons and Social Icons blocks also use. This means that the attribute structure in Navigation block markup has changed slightly, so it would be good to update the Navigation blocks in Twenty Twenty Two templates accordingly.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Currently we have e.g.: <!-- wp:navigation {"itemsJustification":"right","isResponsive":true} --> . With layout, this should change to <!-- wp:navigation {"layout":{"type":"flex","setCascadingProperties":true,"justifyContent":"right"}} /-->. (is-responsive is now on by default so it's no longer necessary to specify it.)
Nothing should break if using the old attributes, because there is a deprecation in place to handle them, but as this is the default theme shipping with 5.9 it would be nice to use the latest markup 🙂
The text was updated successfully, but these errors were encountered:
Oh, I see the issue. Sorry, there's a typo in my snippet; it shouldn't have the closing slash because the navigation block in the template has a closing tag already 🤦
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The Navigation block was updated in WordPress/gutenberg#36169 to use the new layout controls, such as Query loop, Row, Buttons and Social Icons blocks also use. This means that the attribute structure in Navigation block markup has changed slightly, so it would be good to update the Navigation blocks in Twenty Twenty Two templates accordingly.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Currently we have e.g.:
<!-- wp:navigation {"itemsJustification":"right","isResponsive":true} -->
. With layout, this should change to<!-- wp:navigation {"layout":{"type":"flex","setCascadingProperties":true,"justifyContent":"right"}} /-->
. (is-responsive
is now on by default so it's no longer necessary to specify it.)Nothing should break if using the old attributes, because there is a deprecation in place to handle them, but as this is the default theme shipping with 5.9 it would be nice to use the latest markup 🙂
The text was updated successfully, but these errors were encountered: