You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm evaluating this plugin for use in my client's projects. Unfortunately, generating QR codes using googleapis is a hard no-go for them. Having a filter hook in get_google_qr_code would allow me to use a local QR generator instead.
Adding a filter hook in that function should be pretty straightforward, and I don't think it would introduce any other issues?
The text was updated successfully, but these errors were encountered:
@roytanck I can totally relate to that concern. It would be great to replace it with a local QR generator as discussed in #42. There is an attempt to fix this in #388 but the changeset appear to be pretty large.
I won't mark this as duplicate of #42 since this asks for a filter instead of removing the external dependency completely.
Yes, adding a PHP QR generator will likely introduce a lot of code. That's why I proposed a hook, so it can be done in an add-on plugin (one of which I already have to enforce 2FA and remove soem methods my client doesn't need).
I imagine that such a hook could remain in place, even if a local generator is implemented later.
I'm evaluating this plugin for use in my client's projects. Unfortunately, generating QR codes using googleapis is a hard no-go for them. Having a filter hook in
get_google_qr_code
would allow me to use a local QR generator instead.Adding a filter hook in that function should be pretty straightforward, and I don't think it would introduce any other issues?
The text was updated successfully, but these errors were encountered: