Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom CSS outputting HTML entities instead of correct characters #678

Closed
megmorsie opened this issue Mar 17, 2021 · 2 comments · Fixed by #746
Closed

Custom CSS outputting HTML entities instead of correct characters #678

megmorsie opened this issue Mar 17, 2021 · 2 comments · Fixed by #746
Assignees
Labels
[Component] Themes & Customization Custom WC Themes, compatibility with core themes, and theme-adjacent customizations to sites [Type] Bug [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase

Comments

@megmorsie
Copy link

Describe the bug

I compared to a fresh WordPress install to verify, it seems like it's only happening on WordCamp sites. The > symbol is being output as > in the customizer CSS output.

To reproduce

Steps to reproduce the behavior:

  1. Log into a WordCamp site with admin access.
  2. Click on Customize > Custom CSS.
  3. Enter CSS with > selector.
    My example uses:
    #subscribe-submit > button { background: gray; }
  4. Notice preview updates.
  5. Publish & look at Customizer output in inspector, > is replaced with >

Might be related to #574?

Expected behavior

I would expect the output to have > since it's a proper CSS selector. Or if it must be sanitized out, showing an error message or something to indicate that it's not an allowed character would be nice.

Screenshots

I made a screen recording comparing the WordCamp site with a fresh WP install.

WordCamp

Noticed on NEO but I'm guessing other sites have the same issue.

System (please complete the following information):

  • Device: MacBook
  • OS: MacOS
  • Browser: Firefox
  • Version: 86.0.1
@timiwahalahti timiwahalahti added [Component] Themes & Customization Custom WC Themes, compatibility with core themes, and theme-adjacent customizations to sites [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase [Priority] 1 [Type] Bug labels Mar 18, 2021
@ryelle ryelle self-assigned this Aug 29, 2021
@CdrMarks
Copy link
Collaborator

CdrMarks commented Nov 1, 2021

This also affects the make.wordpress.org network (per Dion).

I opened Automattic/jetpack#21603 earlier today.

@CdrMarks
Copy link
Collaborator

CdrMarks commented Nov 17, 2021

The Remote CSS Plugin can be used as a workaround if needed. I tested it on Birmingham 2022 and was able to see > show as the symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Themes & Customization Custom WC Themes, compatibility with core themes, and theme-adjacent customizations to sites [Type] Bug [Type] Good First Issue Straightforward, self-contained, doesn't require deep knowledge of codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants