Changes from feedback

Author: dmsnell

src/wp-includes/html-api/class-wp-html-attribute-token.php

@@ -15,7 +15,7 @@
  *
  * @access private
  * @since 6.2.0
- * @since {WP_VERSION} Replaced `end` with `length` to more closely match `substr()`.
+ * @since 6.5.0 Replaced `end` with `length` to more closely match `substr()`.
  *
  * @see WP_HTML_Tag_Processor
  */
@@ -57,7 +57,10 @@ class WP_HTML_Attribute_Token {
 	public $start;
 
 	/**
-	 * Byte length of the entire attribute name or name and value pair expression.
+	 * Byte length of text spanning the attribute inside a tag.
+	 *
+	 * This span starts at the first character of the attribute name
+	 * and it ends
 	 *
 	 * Example:
 	 *
@@ -70,7 +73,7 @@ class WP_HTML_Attribute_Token {
 	 *     <a rel=noopener>
 	 *        ------------ length is 11
 	 *
-	 * @since {WP_VERSION}
+	 * @since 6.5.0 Replaced `end` with `length` to more closely match `substr()`.
 	 *
 	 * @var int
 	 */
@@ -89,6 +92,7 @@ class WP_HTML_Attribute_Token {
 	 * Constructor.
 	 *
 	 * @since 6.2.0
+	 * @since 6.5.0 Replaced `end` with `length` to more closely match `substr()`.
 	 *
 	 * @param string $name         Attribute name.
 	 * @param int    $value_start  Attribute value.

src/wp-includes/html-api/class-wp-html-span.php

@@ -18,7 +18,7 @@
  *
  * @access private
  * @since 6.2.0
- * @since {WP_VERSION} Replaced `end` with `length` to more closely align with `substr()`.
+ * @since 6.5.0 Replaced `end` with `length` to more closely align with `substr()`.
  *
  * @see WP_HTML_Tag_Processor
  */
@@ -27,14 +27,16 @@ class WP_HTML_Span {
 	 * Byte offset into document where span begins.
 	 *
 	 * @since 6.2.0
+	 *
 	 * @var int
 	 */
 	public $start;
 
 	/**
 	 * Byte length of span.
 	 *
-	 * @since {WP_VERSION}
+	 * @since 6.5.0
+	 *
 	 * @var int
 	 */
 	public $length;

src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -337,7 +337,7 @@ class WP_HTML_Tag_Processor {
 	 *     01234
 	 *     - token starts at 0
 	 *
-	 * @since {WP_VERSION}
+	 * @since 6.5.0
 	 *
 	 * @var int|null
 	 */
@@ -356,7 +356,7 @@ class WP_HTML_Tag_Processor {
 	 *     0123456789 123456789 123456789
 	 *     - token length is 17 - 2 = 15
 	 *
-	 * @since {WP_VERSION}
+	 * @since 6.5.0
 	 *
 	 * @var int|null
 	 */
@@ -372,6 +372,7 @@ class WP_HTML_Tag_Processor {
 	 *      - tag name starts at 1
 	 *
 	 * @since 6.2.0
+	 *
 	 * @var int|null
 	 */
 	private $tag_name_starts_at;
@@ -386,6 +387,7 @@ class WP_HTML_Tag_Processor {
 	 *      --- tag name length is 3
 	 *
 	 * @since 6.2.0
+	 *
 	 * @var int|null
 	 */
 	private $tag_name_length;
@@ -1995,6 +1997,14 @@ public function has_self_closing_flag() {
 			return false;
 		}
 
+		/*
+		 * The self-closing flag is the solidus at the _end_ of the tag, not the beginning.
+		 *
+		 * Example:
+		 *
+		 *     <figure />
+		 *             ^ this appears one character before the end of the closing ">".
+		 */
 		return '/' === $this->html[ $this->token_starts_at + $this->token_length - 1 ];
 	}