PHP: Revisit the default umask, consider 022 #1571

adamziel · 2024-07-03T15:35:42Z

Related to this Studio issue:

tl;dr the permissions of files newly created by PHP.wasm are not aligned with the default unix values. It seems like an Emscripten-level issue:

We'll need either an Emscripten PR or a Playground-level patch.

mho22 · 2024-07-08T12:06:30Z

I found an open pull request on Emscripten : #17270 .

They need a test to validate the PR. I have no idea how to do this. But I would be glad to see this PR merged.

[ BTW we probably need 022 instead of 027 ]

fluiddot · 2024-09-19T17:40:24Z

👋 I've created a PR to update the default umask in Emscripten: emscripten-core/emscripten#22589

fluiddot · 2024-09-23T17:10:14Z

emscripten-core/emscripten#22589 has been merged, so once a new version of Emscripten is released, we could upgrade it as we did in #1471.

adamziel · 2024-09-23T18:02:41Z

Lovely work @fluiddot, thank you!

adamziel added this to Playground Board Jul 3, 2024

adamziel converted this from a draft issue Jul 3, 2024

adamziel changed the title ~~Revisit the default umask, consider 022~~ PHP: Revisit the default umask, consider 022 Jul 3, 2024

adamziel moved this from Inbox to Needs Triage/Our Reply in Playground Board Jul 9, 2024

Provide feedback