Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table design #492

Closed
ndiego opened this issue Feb 2, 2024 · 4 comments · Fixed by #495
Closed

Improve table design #492

ndiego opened this issue Feb 2, 2024 · 4 comments · Fixed by #495
Assignees
Labels

Comments

@ndiego
Copy link
Member

ndiego commented Feb 2, 2024

I just noticed that the table design feels a bit unfinished. Here is an example on the FAQ page. Based on the Figma design, I don't think the white lines are supposed to be there.

image

cc @marko-srb @fcoveram

@ryelle
Copy link
Contributor

ryelle commented Feb 2, 2024

You're right, it should be like this:

Screenshot 2024-02-02 at 11 54 55 AM

It's a technical problem— the issue is that the handbook content is not actually using gutenberg, it's just faking the right classes, but core only loads the table CSS if the block is on the page.

(this is also why #414 will be harder than "just turn it on.")

@ryelle
Copy link
Contributor

ryelle commented Feb 2, 2024

@ndiego Do you still want design feedback here, or should this just be marked to fix?

@ndiego
Copy link
Member Author

ndiego commented Feb 2, 2024

@ndiego Do you still want design feedback here, or should this just be marked to fix?

Yeah, I think we can just move ahead with a fix. Thanks for the context!

@ndiego
Copy link
Member Author

ndiego commented Feb 2, 2024

this is also why #414 will be harder than "just turn it on."

Yeah, I wish there was a way to automatically convert the markdown into blocks behind the scenes. That would make everything a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants