Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local nav doesn't fit on vertical tablet sized screens #80

Closed
adamwoodnz opened this issue Jan 30, 2024 · 3 comments · Fixed by WordPress/wporg-mu-plugins#573
Closed
Labels
[Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Jan 30, 2024

Describe the bug
The items on the right of the local nav are too wide to fit next to the homepage link on sub pages, and get pushed below, breaking the layout.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wordpress.org/documentation/article/updating-wordpress/
  2. Ensure your screen size is 768px wide (typical tablet device or devtools)
  3. Observe the local nav bar below the global header

Expected behavior
The local nav items should be centrally vertically aligned with the home link (like larger screens), or collapsed into a menu (like smaller screens).

Screenshots

Desktop (please complete the following information):

  • MacOS
  • Chrome devtools
@adamwoodnz adamwoodnz added [Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working labels Jan 30, 2024
@ryelle
Copy link
Collaborator

ryelle commented Jan 31, 2024

It looks like the issue is this nav is longer than we expect. We do break to the chevron dropdown at 600px, but when the site title is in the nav, it starts wrapping at 779px. This will only become more of an issue when the page title is added to the nav bar (see L3: WordPress/wporg-mu-plugins#535 (comment) - cc @fcoveram)

Screenshot 2024-01-31 at 6 09 58 PM

It also happens on the homepage at <675px wide:

Screenshot 2024-01-31 at 6 09 15 PM

@fcoveram
Copy link

fcoveram commented Feb 1, 2024

Thanks for noticing it. I will work on an idea for this and share the proposal in wporg-mu-plugins#535 to keep the design discussion in one place.

@ryelle
Copy link
Collaborator

ryelle commented Feb 2, 2024

Moved this issue to "on hold" while WordPress/wporg-mu-plugins#535 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants