-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards compatibility for webp images. #112
Comments
What browser were you using that they're broken? According to caniuse, webp is pretty broadly supported except for IE11 — and I don't think we need to support IE. |
macOs: Catalina Via BrowserStack |
Do we have any statistics that say we need to support back to Safari 13? My hesitation is that I don't know if there is a core/editor-supported way to provide fallbacks, so would we need to stop using |
A quick look at analytics reveals: 0.6% of users are using Safari 13.X. That number inches slightly higher if we account for lesser versions. While 0.6% may feel small, it does account for a significant number of real people. |
I don't know if we need to necessarily serve a fallback image, but it should probably not look broken. |
For reference, some images work and some don't ( Anyway, to get this to "readable," we need to add a background to the editor section. The missing community image is awkward but not critical to understanding the page. screenshot from browserstack |
I ran into this, while testing #111. If we are going to fix the layout for containers, we should probably do the same for these images that are rendering as broken images.
Originally posted by @dd32 in #42 (comment)
The text was updated successfully, but these errors were encountered: