-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Explore clearer focus style that doesn't look like an active section, and don't show on mobile #372
Comments
You can still use a keyboard with a touchscreen device, so we should not hide the focus like this. Instead, we can try using |
Sound good! |
From WordPress/wporg-main-2022#221
Here are screenshots. Homepage:
Download page:
In both cases here, "News" is underlined.
Technically this happens because the overlay menu is a modal dialog, which has to set focus on the first menu item. In other words, the underline represents the focus style. To rectify this, let's do two things:
1. Don't show this focus style on a touchscreen device, where you can't use tab to navigate anyway
We can very probably hide it using code like this:
Let's separately explore a better focus style that can ideally be generic and the same across the entire website, and look more like a focus style. A quick mockup in the inspector:
box-shadow: 0 0 0 1.5px #7b90ff
.This focus style is the same inside the block editor.
The text was updated successfully, but these errors were encountered: