Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP.org Search: The block inside is not full width, and has a label above #555

Closed
jasmussen opened this issue Dec 20, 2023 · 2 comments
Closed
Assignees
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Block] Header & Footer

Comments

@jasmussen
Copy link
Collaborator

Screenshot 2023-12-20 at 18 08 19

The block should be full width, we shouldn't show an added search label above the box.

This is similar to search boxes elsewhere:

Screenshot 2023-12-20 at 18 12 03

Screenshot 2023-12-20 at 18 14 06

@adamwoodnz adamwoodnz added the Accessibility Issues related to keyboard navigation, screen readers, etc label Dec 20, 2023
@ryelle ryelle transferred this issue from WordPress/wporg-main-2022 Jan 10, 2024
@ryelle
Copy link
Contributor

ryelle commented Jan 10, 2024

Looks like there was a regression somewhere, that padding should not be there. But the label is intentional, it was decided here to bring back the visible label since the placeholder is instructional.

management note: I moved this to the wporg-mu-plugins because that controls the header search box

@ryelle
Copy link
Contributor

ryelle commented Jan 10, 2024

Pulling in the comment from #550 that the search spacing is also broken on small screens, it should have spacing here:

Production Expectation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Block] Header & Footer
Projects
Archived in project
Development

No branches or pull requests

3 participants