Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs aren't read individually by NVDA #644

Open
adamwoodnz opened this issue Jun 23, 2023 · 3 comments
Open

Breadcrumbs aren't read individually by NVDA #644

adamwoodnz opened this issue Jun 23, 2023 · 3 comments
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Type] Bug Something isn't working

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Jun 23, 2023

As explained by @alexstine

This is a Windows-specific bug. Voiceover and Windows screen readers work differently in the way that Voiceover traverses the content one item at a time where NVDA reads the links like a sentence due to the display: inline; set. I think that is okay for breadcrumbs, but to get the best verbosity results, it needs to be "Link 1, Link2, etc." Breadcrumbs can be tricky... I wonder what would happen if we tried rendering them as display: block;. Then there likely would not be a need for the screen reader text anymore.

We should try using display: block breadcrumbs within a flex row container if the attempted fix in WordPress/Learn#1641 doesn't work.

@adamwoodnz
Copy link
Contributor Author

We should re-test this behaviour with the new theme.

@adamwoodnz
Copy link
Contributor Author

I've tried testing this with NVDA and the new theme, which uses our shared breadcrumbs block used across all the redesigned sites.

I used D to navigate to the breadcrumb navigation landmark and the whole string was read as follows: 'Breadcrumbs navigation landmark visited link Home slash visited link Courses slash Using the WordPress Data Layer'. Using arrow keys to navigate each section didn't work. It sounds like this is not the ideal behaviour and if so we'll need to create a worg-mu-plugins issue to fix it centrally.

@alexstine does this sound like the next step based on this behaviour?

@alexstine
Copy link
Contributor

@adamwoodnz Looks like the breadcrumbs don't follow the standard unordered list format. I would add them in an unordered list. Something like this as a start.

<ul>
<li><a href="https://learn.wordpress.org">Learn Home<span class="separator" aria-hidden="true"></span></a></li>
<li><a class="current" aria-current="true" href="https://learn.wordpress.org/courses">Courses</a></li>
</ul>

In CSS, you can do your list style type set to none and make sure links remain block, not inline.

Thanks.

@adamwoodnz adamwoodnz transferred this issue from WordPress/Learn Jul 24, 2024
@adamwoodnz adamwoodnz moved this from 🛑 Pending discussion to 📋 To do in WordPress.org Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues related to keyboard navigation, screen readers, etc [Type] Bug Something isn't working
Projects
Status: 📋 To do
Development

Successfully merging a pull request may close this issue.

2 participants