Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global header remains sticky even though the shared component has been unstuck #409

Closed
adamwoodnz opened this issue Nov 8, 2023 · 0 comments · Fixed by #431
Closed

Global header remains sticky even though the shared component has been unstuck #409

adamwoodnz opened this issue Nov 8, 2023 · 0 comments · Fixed by #431
Assignees
Labels
[Component] Theme Front-end help needed [Type] Bug Something isn't working

Comments

@adamwoodnz
Copy link
Contributor

adamwoodnz commented Nov 8, 2023

After WordPress/wporg-mu-plugins#466 is merged, the global header should not be sticky anymore, and only the local nav should be.

Steps to reproduce:

  1. Set your mu-plugins to Global Header: Try unsticking the global header, making local navigation sticky wporg-mu-plugins#466
  2. Scroll the home page
  3. Expect the global header to not be sticky, but it still is

Extra work will be required to make the local nav sticky, separate from the global header. https://wordpress.org/download/releases/ has almost the same header style.

@adamwoodnz adamwoodnz added the [Type] Bug Something isn't working label Nov 8, 2023
@adamwoodnz adamwoodnz self-assigned this Sep 23, 2024
@adamwoodnz adamwoodnz moved this to 📋 To do in WordPress.org Sep 23, 2024
@adamwoodnz adamwoodnz added the [Component] Theme Front-end help needed label Sep 23, 2024
@ryelle ryelle assigned ryelle and unassigned adamwoodnz Oct 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in WordPress.org Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Front-end help needed [Type] Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants