Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge/bottom background to query title banner #69

Closed
3 tasks done
iandunn opened this issue Nov 5, 2021 · 1 comment
Closed
3 tasks done

Add edge/bottom background to query title banner #69

iandunn opened this issue Nov 5, 2021 · 1 comment
Labels
[Type] Enhancement New feature or request

Comments

@iandunn
Copy link
Member

iandunn commented Nov 5, 2021

#64 restored the query-title-banner. in some situations, though, it needs to have the edge/bottom background added instead of the local nav.

  • query-title-banner should always have the edge/bottom background
  • When query-title-banner isn't shown, the local nav should have the edge/bottom background
  • Probably setup an @extend %header-edge-background mixin like 298bb0b did, to make the styles DRY

Could maybe just move the query title template part inside of the local header template part, so that the container is the one that always has the background. That'd be simpler, but would require hiding the banner w/ CSS on screens where it's not desired, which is a bit hacky. It could be made cleaner once WordPress/gutenberg#32939 is solved. the "all posts" part shouldn't be position: fixed, though, only the admin bar, global header, and local nav

related #67

@iandunn
Copy link
Member Author

iandunn commented Nov 20, 2021

Fixed by b2ea203

@iandunn iandunn closed this as completed Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant