Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment form inputs and textarea missing borders #147

Closed
kathrynwp opened this issue Jul 23, 2024 · 1 comment
Closed

Comment form inputs and textarea missing borders #147

kathrynwp opened this issue Jul 23, 2024 · 1 comment
Labels
[Component] Theme Templates, patterns, CSS

Comments

@kathrynwp
Copy link

Describe the bug
It's very easy to miss the comment form at the bottom of each documentation page as it has no border, coloured background, or any other visual identifier

To Reproduce

Visit any documentation page with a feedback form at the bottom, in the section with the heading "Was this article helpful? How could it be improved?"

Notification_Center

Screenshot taken at https://wordpress.org/documentation/article/group-block/

Expected behavior
The textarea should have a border or some other way to make it clear that there's a form field there.

Desktop (please complete the following information):

  • OS: macOS 14.5 (Sonoma)
  • Browser: Firefox 127 & Chrome 126
@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label Jul 23, 2024
@ryelle ryelle transferred this issue from WordPress/wporg-documentation-2022 Jul 31, 2024
@ryelle
Copy link
Contributor

ryelle commented Jul 31, 2024

Moved to the parent theme repo, since this was also reported on developer — https://developer.wordpress.org/news/2024/07/30/building-a-card-layout-with-a-hover-reveal-effect/

Seems to be a result of WordPress/gutenberg#62960; previously the default comment form styles added a border, but now that they're lower specificity, our textarea reset is overriding it.

This can be styled (kind of) with a CSS string in theme.json, or maybe rethink the form reset? The following does not work because the input[type…]s are a higher specificity.

"core/post-comments-form": {
  "css": "& textarea, input { border: 5px solid red; }"
},

Alternately, maybe set the custom properties differently when in the form? They're 0 solid transparent by default (to reset the search field).

border: var(--wp--custom--form--border--width) var(--wp--custom--form--border--style) var(--wp--custom--form--border--color)

@ryelle ryelle changed the title Feedback form at bottom of Docs pages is missing a border Comment form inputs and textarea missing borders Jul 31, 2024
@ryelle ryelle closed this as completed in e8c2e50 Aug 1, 2024
@github-project-automation github-project-automation bot moved this from 📋 To do to ✅ Done in WordPress.org Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Archived in project
Development

No branches or pull requests

2 participants