Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider merging "Flavors" with "Tags" #230

Open
ndiego opened this issue Oct 9, 2023 · 5 comments · May be fixed by #241
Open

Consider merging "Flavors" with "Tags" #230

ndiego opened this issue Oct 9, 2023 · 5 comments · May be fixed by #241
Labels
[Component] Content Bugs or issues related to the page content [Status] In Discussion The implementation of this idea is still being worked out [Type] Enhancement New feature or request
Milestone
Future

Comments

@ndiego
Copy link
Member

ndiego commented Oct 9, 2023

Flavors were implemented in Showcase v2 to keep the functionality consistent with the current Showcase. After using the v2 site, the third taxonomy feels burdensome as a user. There are too many things to search by, and it is unclear what "Flavor" means.

Homepage Single Site
image image

Therefore, I propose that we convert the existing Flavors into tags. We can ignore "WordPress.org", so only "WordPress Multisite" and "WordPress VIP" would be added as tags. Then:

  • Update any sites with these Flavors with the new corresponding tags
  • Remove the Flavor filter from the Homepage, Search/Filter Results, and All Sites pages
  • Remove the Flavor row from the Single Sites template
  • Remove the Flavor selector from the Submit a Site form

I don't think we should remove the Flavor taxonomy entirely at the moment, just remove the visual presence on the front end. There may be a use case in the future. But for now, tags and categories suffice.

cc @marko-srb @jasmussen @eidolonnight
@jasmussen
Copy link

No strong opinion on my part.

@ndiego
Copy link
Member Author

ndiego commented Oct 10, 2023

@marko-srb @fcoveram any thoughts on this one? If you both are comfortable moving forward, I can get this in motion. Thanks!

@renintw renintw self-assigned this Oct 11, 2023
@renintw renintw added this to the Launch milestone Oct 11, 2023
@renintw
Copy link
Contributor

renintw commented Oct 11, 2023 •
edited
Loading

I'll remove flavors from these places:

1. Homepage Filter. Search Page Filter. Archive Page Filter👇
image

2. Browse (copy would change to Browse by category or tag, thoughts on this?) 👇
image

3. Single Page 👇
image

@renintw renintw assigned renintw and unassigned renintw Oct 11, 2023
@renintw renintw linked a pull request Oct 11, 2023 that will close this issue
Open
@renintw renintw added [Type] Enhancement New feature or request [Component] Content Bugs or issues related to the page content labels Oct 11, 2023
@ndiego ndiego moved this from In Progress to On hold/blocked in WordPress.org Redesign: Showcase Oct 11, 2023
@ndiego ndiego modified the milestones: Launch, Future Oct 11, 2023
@ndiego ndiego added the [Status] In Discussion The implementation of this idea is still being worked out label Oct 11, 2023
@ndiego
Copy link
Member Author

ndiego commented Oct 11, 2023 •
edited
Loading

After further discussion, let's put this enhancement on hold. Sorry for the extra work here! For now, we will keep feature parity with the current Showcase (which includes Flavors), and then we will reassess in the future.

@marko-srb
Copy link

I think its ok to hide the Flavors, but also think this could wait to post-launch.

@ryelle ryelle moved this to 🛑 Pending discussion in WordPress.org Jan 10, 2024
@ryelle ryelle moved this from 🛑 Pending discussion to ⚠ On Hold/Blocked in WordPress.org Jan 10, 2024
@renintw renintw removed their assignment Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Content Bugs or issues related to the page content [Status] In Discussion The implementation of this idea is still being worked out [Type] Enhancement New feature or request
Projects
WordPress.org
Status: ⚠ On Hold/Blocked
WordPress.org Redesign: Showcase
Status: On hold/blocked
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Remove Flavors UI WordPress/wporg-showcase-2022
5 participants
@jasmussen @ndiego @renintw @marko-srb and others