Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TOTP class with our own, to encrypt all the things #101

Closed
dd32 opened this issue Apr 5, 2023 · 0 comments · Fixed by #103
Closed

Replace TOTP class with our own, to encrypt all the things #101

dd32 opened this issue Apr 5, 2023 · 0 comments · Fixed by #103
Assignees
@dd32
Labels
priority: high
Milestone
MVP

Comments

@dd32
Copy link
Member

dd32 commented Apr 5, 2023

Using WordPress/two-factor#546 we should replace the core TOTP class with our own instance of it and encrypt the secret that's being stored in the database.

See the above PR for an example of the class we could implement.
@dd32 dd32 added this to the Iteration 1 milestone Apr 5, 2023
@dd32 dd32 changed the title Replace TOTP class with our own Replace TOTP class with our own, to encrypt all the things Apr 5, 2023
@StevenDufresne StevenDufresne modified the milestones: Iteration 1, MVP Apr 6, 2023
@dd32 dd32 mentioned this issue Apr 12, 2023
Merged
4 tasks
@dd32 dd32 self-assigned this Apr 12, 2023
@dd32 dd32 closed this as completed in #103 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dd32 dd32

Labels
priority: high
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Encrypt TOTP keys WordPress/wporg-two-factor
2 participants
@dd32 @StevenDufresne