Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Language #29

Closed
iandunn opened this issue Dec 13, 2022 · 4 comments
Closed

UI: Language #29

iandunn opened this issue Dec 13, 2022 · 4 comments
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Dec 13, 2022

Implement the language field in the custom UI, see #18 for rough mockups

@iandunn iandunn added this to the MVP milestone Dec 13, 2022
@dd32
Copy link
Member

dd32 commented Dec 14, 2022

What does this Language selector actually do?

AFAIK it probably only controls the wp-admin locale - if so, we can ditch this field.

@iandunn
Copy link
Member Author

iandunn commented Dec 14, 2022

Yeah, it's just the user locale setting. I would guess that there's some front end stuff that it affects as well, like learn.wordpress.org and a few other places that have front-end localization. It seems like it'd be important to keep, since we're planning for more of that in the future. Does that seem right to you?

@dd32
Copy link
Member

dd32 commented Dec 15, 2022

I would guess that there's some front end stuff that it affects as well, like learn.wordpress.org and a few other places that have front-end localization.

If that were the case, yeah, I would agree with keeping it.

However, it's not actually used anywhere other than wp-admin at present that I'm aware of, including learn.w.org.

The thing it affects is get_user_locale() which is only used for the requests within wp-admin by default in https://developer.wordpress.org/reference/functions/determine_locale/

Looking closer, it looks like all plugins on dotorg only use it within wp-admin, aside from the Pattern Directory which appears to respect it for notifications.

Given it's lack of use, I suggest we skip the field for now, given it doesn't actually affect the majority of users, there's a good chance whatever data we've stored in there might not even be correct.

@iandunn
Copy link
Member Author

iandunn commented Dec 15, 2022

That WFM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants