-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Language #29
Comments
What does this Language selector actually do? AFAIK it probably only controls the wp-admin locale - if so, we can ditch this field. |
Yeah, it's just the user locale setting. I would guess that there's some front end stuff that it affects as well, like learn.wordpress.org and a few other places that have front-end localization. It seems like it'd be important to keep, since we're planning for more of that in the future. Does that seem right to you? |
If that were the case, yeah, I would agree with keeping it. However, it's not actually used anywhere other than The thing it affects is Looking closer, it looks like all plugins on dotorg only use it within wp-admin, aside from the Pattern Directory which appears to respect it for notifications. Given it's lack of use, I suggest we skip the field for now, given it doesn't actually affect the majority of users, there's a good chance whatever data we've stored in there might not even be correct. |
That WFM 👍🏻 |
Implement the language field in the custom UI, see #18 for rough mockups
The text was updated successfully, but these errors were encountered: