Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documenation and Examples Modal Buttons #2871

Closed
jaclynjessup opened this issue Aug 15, 2024 · 0 comments
Closed

Update Documenation and Examples Modal Buttons #2871

jaclynjessup opened this issue Aug 15, 2024 · 0 comments
Assignees
@josh-bagwell
Labels
documentation Affects documentation on hold PR is on hold until further notice ready for review Code is ready for review

Comments

@jaclynjessup
Copy link
Member

jaclynjessup commented Aug 15, 2024 •
edited
Loading

💡 Suggestion

Update the guidance & examples on Modal Button Alignment

Motivation

Alignment with new guidance on how the buttons should be aligned
@josh-bagwell josh-bagwell self-assigned this Aug 28, 2024
@josh-bagwell josh-bagwell added the documentation Affects documentation label Aug 28, 2024
@josh-bagwell josh-bagwell mentioned this issue Sep 3, 2024
Closed
@josh-bagwell josh-bagwell added the ready for review Code is ready for review label Sep 4, 2024
@jaclynjessup jaclynjessup linked a pull request Sep 9, 2024 that will close this issue
chore: Modal Button Examples Update #2904
Closed
@myvuuu myvuuu added the on hold PR is on hold until further notice label Sep 24, 2024
@github-actions github-actions bot closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josh-bagwell josh-bagwell

Labels
documentation Affects documentation on hold PR is on hold until further notice ready for review Code is ready for review
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Modal Button Examples Update josh-bagwell/canvas-kit
3 participants
@jaclynjessup @josh-bagwell @myvuuu