Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the visual difference between the Toolbar Icon Button on/off state #2884

Open
myvuuu opened this issue Aug 22, 2024 · 1 comment
Open
Labels
needs-a11y Extra attention from accessibility is needed needs-design Extra attention from design is needed

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Aug 22, 2024

💡 Suggestion

Update toggle on and off state of the Toolbar Icon button to be more visually distinct.

Success Criteria

  • The toggle on and off state of the Toolbar Icon Button are visually distinct (color contrast between on and off background must exceed 3:1 OR the component design can be altered to increase the distinction by inverting the color scheme, adding an outline, etc.)
  • Toolbar Icon Button utilizes the new set of css variable tokens

Motivation

The toggle on and off state of the Toolbar Icon button isn't visually distinct enough for users with low vision / color blindness to defer the toggle state based on color alone.

Example

Please provide some examples of this suggestion in practice.

@myvuuu myvuuu added the needs-a11y Extra attention from accessibility is needed label Aug 22, 2024
@williamjstanton
Copy link
Collaborator

Suggesting under Motivation:
To improve conformance with WCAG 2.2 guidelines 1.4.1 Use of color and 1.4.11 Non-text contrast.

Toggle buttons with an inverted color scheme:
jira format toolbar

Toggle buttons with an outline:
outlook format toolbar

Toggle buttons with a fill or no-fill scheme:
slack-fill-no-fill

@myvuuu myvuuu changed the title Increase the contrast for the hover state of the Toolbar Icon Button Increase the visual difference between the Toolbar Icon Button on/off state Sep 3, 2024
@myvuuu myvuuu added the needs-design Extra attention from design is needed label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-a11y Extra attention from accessibility is needed needs-design Extra attention from design is needed
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants