Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default our Popups to use React Portal #517

Closed
mannycarrera4 opened this issue Mar 16, 2020 · 3 comments
Closed

Default our Popups to use React Portal #517

mannycarrera4 opened this issue Mar 16, 2020 · 3 comments
Assignees
@mannycarrera4
Labels
4.x enhancement New feature or request
Milestone
v4.0.0

Comments

@mannycarrera4
Copy link
Contributor

mannycarrera4 commented Mar 16, 2020 •
edited
Loading

🚀 Feature Proposal

Based off of this PR #419 there's been discussion to make all of our Popups to default to using Portal . This issue is to convert the rest of our Popups including Toast, and Tooltips to use Portal as well.
@jpante jpante added enhancement New feature or request p:2 4.x labels Mar 17, 2020
@jpante jpante added this to the v4.0.0 milestone Mar 25, 2020
@jpante jpante removed the p:2 label Mar 31, 2020
@jpante
Copy link
Member

jpante commented Mar 31, 2020 •
edited by anicholls
Loading

Tooltips are being covered by #528

@mannycarrera4 mannycarrera4 mentioned this issue Apr 1, 2020
Closed
9 tasks
@NicholasBoll NicholasBoll mentioned this issue Apr 7, 2020
Merged
7 tasks
@anicholls
Copy link
Contributor

@NicholasBoll the popper upgrade in #528 did this for all popups correct? Can we close this?

@anicholls
Copy link
Contributor

Closed by #528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannycarrera4 mannycarrera4

Labels
4.x enhancement New feature or request
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

refactor(popper): Update to use react portal as default
3 participants
@anicholls @jpante @mannycarrera4