Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ref forwarding on Icon components #574

Closed
laurenraddatz opened this issue Apr 15, 2020 · 1 comment · Fixed by #707
Closed

Implement ref forwarding on Icon components #574

laurenraddatz opened this issue Apr 15, 2020 · 1 comment · Fixed by #707
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@laurenraddatz
Copy link
Contributor

laurenraddatz commented Apr 15, 2020

🚀 Feature Proposal

I am requesting to add an iconRef prop on the icon components, and forwarding it to the ref prop on the icon components.

Motivation

this is already enabled in the button components, such as IconButton. In our use case, we have refs with interesting types, such as ones that are callbacks.

Example

reference the IconButton component.

let me know what you think and I can make a PR!

@mannycarrera4
Copy link
Contributor

I think we want to do this for most of our components! For reference: #548

@jpante jpante added p:2 enhancement New feature or request labels Apr 28, 2020
@lychyi lychyi added 5.x and removed 5.x labels May 26, 2020
@alanbsmith alanbsmith self-assigned this May 28, 2020
@jpante jpante added the ready for review Code is ready for review label Jun 9, 2020
@jpante jpante added this to the 4.1.0 milestone Jun 25, 2020
@jaclynjessup jaclynjessup removed p:2 ready for review Code is ready for review labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants