Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide fallback to icon when avatar image fails to load #613

Closed
vibdev opened this issue May 3, 2020 · 1 comment · Fixed by #614
Closed

Provide fallback to icon when avatar image fails to load #613

vibdev opened this issue May 3, 2020 · 1 comment · Fixed by #614

Comments

@vibdev
Copy link
Contributor

vibdev commented May 3, 2020

🚀 Feature Proposal

If the link for the avatar fails, eg 404 etc, we are currently showing a broken link. This could be made a bit nicer by rendering the default icon instead.

Motivation

Broken links look bad.
@NicholasBoll NicholasBoll linked a pull request May 4, 2020 that will close this issue
fix(avatar): Combine Avatar & AvatarButton and provide fallback image #614
Merged
7 tasks
@vibdev vibdev mentioned this issue May 6, 2020
Merged
7 tasks
@NicholasBoll NicholasBoll added the ready for review Code is ready for review label May 12, 2020
@NicholasBoll
Copy link
Member

Closed by #614

@NicholasBoll NicholasBoll mentioned this issue Jun 10, 2020
Closed
@jaclynjessup jaclynjessup removed the ready for review Code is ready for review label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(avatar): Combine Avatar & AvatarButton and provide fallback image vibdev/canvas-kit
3 participants
@NicholasBoll @vibdev @jaclynjessup