Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependency_validator running on analysis_options.yaml files #125

Open
matthewnitschke-wk opened this issue Jun 20, 2024 · 0 comments

Comments

@matthewnitschke-wk
Copy link
Contributor

It is possible, and common practice to add a include: package:<somePackage>/<someEntrypoint>.yaml within an analysis_options.yaml file

For example, this is how pedantic and the newer lints package work

include: package:lints/recommended.yaml

Currently, dependency validator completely ignores this file, but it could, and probably should, audit the dependencies used within these files

I'm proposing the following rules regarding this file:

  • if a dependency is used within the analysis_options.yaml include statement and is not declared within the pubspec.yaml file, the command should fail
  • if a dependency is only used within the analysis_options.yaml include AND is declared as a non-dev dependency, the command should fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant