Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OverReact strong-mode compliant #14

Closed
1 of 2 tasks
jacehensley-wf opened this issue Oct 27, 2016 · 1 comment
Closed
1 of 2 tasks

Make OverReact strong-mode compliant #14

jacehensley-wf opened this issue Oct 27, 2016 · 1 comment
Assignees
@aaronlademann-wf
Labels
Type: enhancement

Comments

@jacehensley-wf
Copy link
Contributor

jacehensley-wf commented Oct 27, 2016 •
edited by greglittlefield-wf
Loading

  • Issue Type: FEATURE REQUEST

We should make OverReact strong-mode compliant. With all the new DDC stuff coming out including the Dart Console, it would be really nice to let our consumers use those new tools.

FYI: @greglittlefield-wf @aaronlademann-wf @clairesarsam-wf @joelleibow-wf
aaronlademann-wf added a commit to aaronlademann-wf/react-dart that referenced this issue Oct 28, 2016
@aaronlademann-wf
Make fields private
a96b884 
+ So that over_react can override them with strong typing
+ Ref: Workiva/over_react#14
aaronlademann-wf added a commit to aaronlademann-wf/react-dart that referenced this issue Oct 28, 2016
@aaronlademann-wf
Add types to React lifecycle method arguments
7282066 
+ Ref: Workiva/over_react#14
This was referenced Oct 28, 2016
Merged
Merged
@aaronlademann-wf aaronlademann-wf self-assigned this Oct 31, 2016
@jacehensley-wf
Copy link
Contributor Author

jacehensley-wf commented Jan 13, 2017 •
edited
Loading

Related issue, WRT transformed code, of what seems like a strong-mode bug: dart-lang/sdk#28369

Scratch that, that warning is valid.

@jacehensley-wf jacehensley-wf mentioned this issue Jun 19, 2017
Merged
@aaronlademann-wf aaronlademann-wf mentioned this issue Jun 21, 2017
Merged
greglittlefield-wf added a commit that referenced this issue Jun 19, 2020
@greglittlefield-wf
Merge pull request #14 from Workiva/link-2020/fix-BoolPropNameReadabi…
162132e 
…lityDiagnostic

Fix BoolPropNameReadabilityDiagnostic
keepsimple7 added a commit to keepsimple7/react-dart-expander that referenced this issue Aug 15, 2022
@keepsimple7
Make fields private
54a51c8 
+ So that over_react can override them with strong typing
+ Ref: Workiva/over_react#14
keepsimple7 added a commit to keepsimple7/react-dart-expander that referenced this issue Aug 15, 2022
@keepsimple7
Add types to React lifecycle method arguments
6a1f8bd 
+ Ref: Workiva/over_react#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronlademann-wf aaronlademann-wf

Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronlademann-wf @jacehensley-wf