Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency maintenance #149

Merged
merged 2 commits into from
May 1, 2018
Merged

Dependency maintenance #149

merged 2 commits into from
May 1, 2018

Conversation

aaronlademann-wf
Copy link
Contributor

Ultimate problem:

  1. This library is not yet compatible with Dart SDK 2.x, yet the SDK upper bound in our pubspec.yaml file was not set.
  2. Various other upper bounds of dependencies can be safely expanded to ease dependency resolutions for consumers.

How it was fixed:

  1. Add SDK upper bound of <2.0.0
  2. Expand upper bounds of dependencies shown in the diff

Testing suggestions:

Passing CI build

Potential areas of regression:

None expected

FYA: @Workiva/ui-platform-pp

@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner April 28, 2018 05:26
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

codecov-io commented Apr 28, 2018 •
edited
Loading

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          33       33           
  Lines        1601     1601           
=======================================
  Hits         1513     1513           
  Misses         88       88

@aaronlademann-wf
Copy link
Contributor Author

QA +1

@Workiva/release-management-pp

@aaronlademann-wf aaronlademann-wf merged commit b3bbe66 into Workiva:master May 1, 2018
@aaronlademann-wf aaronlademann-wf mentioned this pull request May 1, 2018
Merged
@aaronlademann-wf aaronlademann-wf deleted the adjust-dep-ranges branch September 7, 2018 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairesarsam-wf clairesarsam-wf clairesarsam-wf approved these changes

Assignees
No one assigned
Labels
area-dependencies Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronlademann-wf @aviary-wf @codecov-io @clairesarsam-wf @rmconsole-wf