Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Microsoft Edge #39

Open
kenzieschmoll opened this issue Mar 21, 2019 · 1 comment
Open

Support for Microsoft Edge #39

kenzieschmoll opened this issue Mar 21, 2019 · 1 comment

Comments

@kenzieschmoll
Copy link

Are there plans to support Edge?

If it is already supported, feel free to close this, but I didn't see Edge in the list of known browsers. Thanks.

@dotdotcommadot
Copy link

In the source code, the check for browser.isInternetExplorer looks like this:

 static bool _isInternetExplorer(NavigatorProvider navigator) {
    return navigator.appName.contains('Microsoft') ||
        navigator.appVersion.contains('Trident') ||
        navigator.appVersion.contains('Edge');
  }

I assume this means this will check for Edge.
But, I still think the two of them should be separated.
I have a website where we support Edge from at least version '17', and where we don't support Internet Explorer at all.
If the check browser.isInternetExplorer returns true for both IE and Edge, this will not allow us to differentiate between these...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants