Skip to content

Commit b9965ca

Browse files
committed
try using presets instead
1 parent 5cb0631 commit b9965ca

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/dart_ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ jobs:
7474

7575
- name: Run tests (DDC)
7676
run: |
77-
dart run build_runner test --delete-conflicting-outputs --exclude-tags=react-${{ matrix.react == 18 && '17' || '18' }} -- --preset dartdevc
77+
dart run build_runner test --delete-conflicting-outputs -- --preset dartdevc --preset=react${{ matrix.react }}
7878
if: always() && steps.install.outcome == 'success'
7979
timeout-minutes: 8
8080

8181
- name: Run tests (dart2js)
8282
run: |
83-
dart run build_runner test --delete-conflicting-outputs --release --exclude-tags=react-${{ matrix.react == 18 && '17' || '18' }} -- --preset dart2js
83+
dart run build_runner test --delete-conflicting-outputs --release -- --preset dart2js --preset=react${{ matrix.react }}
8484
if: always() && steps.install.outcome == 'success'
8585
timeout-minutes: 8

dart_test.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ presets:
1414
dartdevc:
1515
exclude_tags: no-dartdevc
1616

17+
react18:
18+
exclude_tags: react-17
19+
20+
react17:
21+
exclude_tags: react-18
22+
1723
tags:
1824
# Variadic children tests of >5 children that fail in Dart 2.7 for an unknown reason, seemingly an SDK bug.
1925
# These tests pass in later Dart SDKs, so we ignore them when running in 2.7.

0 commit comments

Comments
 (0)