-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Release #1
Comments
👍 |
@AdmiringWorm as a side note, you might want to make the |
@gep13 not with my work flow, if I set the develop branch as the default issues would close when a commit/PR is merged to the develop branch. |
Interesting... hadn't thought of it that way. The main reason that I do it is so that PR's from external contributors come into the correct branch. 9 times out of 10, they use the default branch, without thinking. |
While that is certainly a problem, I've never had that many PR's on my projects so it's never been I problem for me. Only once that I can remember, in that case I just re-targeted the PR to the develop branch, and asked the submitter to rebase/merge it towards the develop branch. |
We (Cake) have had a few issues with it in the past, but I totally understand your point of view as well. Going to have to mull this one over a bit 😄 |
👍 /cc @gep13 |
GitReleaseManager is based off of the fact that issues have been:
That is not to say that these things won't change in the future, but that is how it currently works. |
yeah, I thought that was the how it worked. Just wanted to make sure, just in case I was missing something. |
Happy to take any input on how it can be done different. That project is somewhat neglected. Need to get back to it at some point. |
Unfortunately I don't know if it is even possible to get a pending closure state (couldn't find any in the api documents). I'll probably open a issue on GitReleaseManager sometime in the future detailing my views on some changes. |
Likely not. Would likely need to be an additional label to provide an indication of current state. i.e
Sounds good to me. |
@AdmiringWorm great work on getting this released 👍 |
@gep13 thanks, had to skip a few corners when trying to build it on osx and linux though. (tooling issues) |
@AdmiringWorm baby steps 😄 So, you doing a PR to the ChocolateyGUI repo next? 😛 |
while I could do that, there would still be some steps that needs to be done before I can. There probably should also be some kind of discussion on whether the translated sources should be checked in or not and if everything should be automated on appveyor or not. |
in the meantime I've updated the Hello Transifex demo project. |
Initial realse of the transifex cake addin which adds support for
status
,push
andpull
.The text was updated successfully, but these errors were encountered: