Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new custom layer feature if possible (at least make an example) #82

Open
Wykks opened this issue Dec 9, 2018 · 11 comments
Open

Comments

@Wykks
Copy link
Owner

Wykks commented Dec 9, 2018

mapbox/mapbox-gl-js#7039

@CodeWithBryan
Copy link

This feature honestly looks so damn promising, very excited for this

@CodeWithBryan
Copy link

Side note - have you made any progress w/ this?

I've got stuff rendering via a custom layer in my project (bypassing ngx-mapbox-gl using the direct map object)

Just trying to figure out the best way to dynamically update custom layers w/ data from my store

@CodeWithBryan
Copy link

Also, What if you moved markers into a purely WebGL existence (instead of custom html/css w/ transforms)

This would provide a great performance benefit to larger amounts of markers and could open doors to more cool things such as custom map drawings via coordinates etc.

@Wykks
Copy link
Owner Author

Wykks commented Jan 28, 2019

Not started yet; but it should not be very complicated.

About your comment on markers stuff, it's already there (and it's recommended, html markers are just a fallback when you need to render html stuff like angular component for example).
https://docs.mapbox.com/mapbox-gl-js/style-spec/#layers-symbol

@CodeWithBryan
Copy link

By the markers, I meant so you could have click/drag events, etc

@Wykks
Copy link
Owner Author

Wykks commented Jan 29, 2019

Already there too, with mgl-layer with point source. https://wykks.github.io/ngx-mapbox-gl/demo/ngx-drag-a-point

Something like a mgl-gl-marker which internally create a layer with one symbol could be done. But I don't think it's a good idea to do this kind of work.
Simply put, I believe that it's better to embrace the way mapbox-gl's layers system works instead of fighting it.

@CodeWithBryan
Copy link

Do you have discord or slack where I can contact you for a quick chat? I wanna pick your brain for two seconds :)

@Wykks

This comment has been minimized.

@dmytro-gokun
Copy link
Collaborator

@Wykks Have this been implemented completely or do you there some more work to do here? Let me know and i'll see if I can finish it.

@Wykks
Copy link
Owner Author

Wykks commented Jul 30, 2020

Nothing implemented here. You can work on it :)

@dmytro-gokun
Copy link
Collaborator

@Wykks Thanks for the answer! Okay, i will assign it to myself and look at it when i have time. Hopefully, soon :)

In any case, anyone interested in this feature is welcome to chime in and give thoughts or submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants