Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assets to the docs folder #60

Open
xparadoxical opened this issue Oct 8, 2024 · 0 comments
Open

Move assets to the docs folder #60

xparadoxical opened this issue Oct 8, 2024 · 0 comments

Comments

@xparadoxical
Copy link

xparadoxical commented Oct 8, 2024

I don't know why the screenshots are referenced as github links, but relative paths work fine for images and let you preview changes locally properly. When using relative paths with docsify, you can't go deeper than the /docs folder (the one being docsify served), which means /assets would have to be moved to /docs/assets, but this makes sense structurally anyway, as /docs is the website root and these are assets of the documentation. The gddocs-icon.png can be left in /assets in repo root.

I'd also move stylesheets and fonts (being added in #59) to the new location of assets.

Not sure if #56 and #59 have to be merged before doing this to get no merge conflicts so I'll wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant