Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could FlyWithLua be extended to support SSL requests #26

Open
aussig opened this issue Jan 4, 2019 · 2 comments
Open

Could FlyWithLua be extended to support SSL requests #26

aussig opened this issue Jan 4, 2019 · 2 comments

Comments

@aussig
Copy link

aussig commented Jan 4, 2019

Although standard http requests are supported with the socket.http module, FlyWithLua doesn't seem to support https requests using the ssl.https module. Would it be possible to add support for this, so the following code would work:

local https = require("ssl.https")
local body, code, headers, status = https.request("https://[domain]")
@nevkontakte
Copy link
Contributor

This could be done if we add support for https://github.com/brunoos/luasec. However, dependency on openssl might make things tricky.

Bundling openssl in is not ideal from maintenance/security perspective, such libraries are better to be maintained and updated via standard OS vendor channels. Linking it dynamically might pose portability issues, because different Linux distros may be using different openssl versions and I don't even know if it is provided by Windows out of box (it isn't if I were to guess...).

That is the reason why I didn't do it from the very beginning. I'd be happy to consult/review if you decide to make an attempt.

@urbanswelt
Copy link

urbanswelt commented Jun 7, 2020

I have seen ZEROBRANE deliver a full package with his IDE Solution.
Maybe as a idea for FWL ?
pkulchenko/ZeroBraneStudio@6d0b497
One thing what i miss is a kind of Security ping for new Security Bug fixes maybe ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants