Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB fields suggestion #36

Open
morfies opened this issue Apr 29, 2022 · 1 comment
Open

DB fields suggestion #36

morfies opened this issue Apr 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@morfies
Copy link

morfies commented Apr 29, 2022

Hi, thanks very much for your project.
Here I would like to add two small suggestions about the sql:

  • I see that some fields are using mysql keywords/reserved words, such as status, owner, name, context.
  • And also DECIMAL that does not lose precision is preferred over FLOAT, DOUBLE precision-loss types, current usage of these fields seem all fine though.
  • id fields maybe can consider bigint unsigned
@hyj1991 hyj1991 added the enhancement New feature or request label Apr 29, 2022
@hyj1991
Copy link
Member

hyj1991 commented Apr 29, 2022

  • And also DECIMAL that does not lose precision is preferred over FLOAT, DOUBLE precision-loss types, current usage of these fields seem all fine though.
  • id fields maybe can consider bigint unsigned

PR is welcom :)

This was referenced May 6, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morfies @hyj1991