Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProjectMaintenance]建立PR模板 #71

Closed
birdflyi opened this issue May 29, 2022 · 0 comments · Fixed by #84
Closed

[ProjectMaintenance]建立PR模板 #71

birdflyi opened this issue May 29, 2022 · 0 comments · Fixed by #84

Comments

@birdflyi
Copy link
Collaborator

birdflyi commented May 29, 2022

一起来建立PR模板吧~
我们可以参考https://raw.githubusercontent.com/X-lab2017/OSSDevGov2021/main/.github/PULL_REQUEST_TEMPLATE.md ,做一个PR模板用于解决文献入库等常规Issue,示例:

<!--
Thank you for your interest in and contributing to xlab-website! Follow this checklist to help us incorporate your contribution quickly and easily:

 - Each commit in the pull request has a meaningful commit message.
 - Fill out the template below to describe the changes contributed by the pull request.
 **(The sections below can be removed for hotfixes of typos)**
-->

## Purpose

<!-- Please include the GitHub issue this fixes or resolves, if applicable, please also explain any extra purpose of this PR  -->

-  Fix # <!--As well as Close # -->

## Changes

<!-- Please list out what major changes were made in this PR to address the issue: -->

- Your changes

为什么推荐使用PR模板?(选读)
不推荐多次commit解决某一个Issue。出于美观,以及考虑到sha-1码查询困难(需要从commit中获取提交信息)、关联到Issue主题难度大、github不支持预览等方面考虑,推荐使用PR解决对应的Issue。示例:Issue #69 Fixed by PR #70
为了方便自动化关联,我们需要一个统一的PR模板。
使用PR的好处:在PR中我们可以提供标签、增加主题说明、多次提交、多人讨论、完整的指派和review流程、增加bus系数、自动化程度高、有github预览等好处~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant