Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error, Function 'CanUnitMeleeFromMove' specifiers differ from original #913

Closed
robojumper opened this issue Sep 18, 2020 · 1 comment
Closed

Comments

@robojumper
Copy link
Member

robojumper commented Sep 18, 2020

This is an information issue regarding this compiler error that may appear when trying to build mods depending on the Highlander.

The issue is that various HL releases starting from 1.20.0 have incorrect source files included. In particular, some files include local modifications made by a HL maintainer that didn't make it into the HL itself.

In concrete terms, XComPathingPawn has a simulated protected function bool CanUnitMeleeFromMove, but some subclasses (X2MeleePathingPawn) had the protected removed, triggering this error.

The intended change was actually made for 1.21.1, so this was thought to be fixed, but X2PathTargetPathingPawn was still left out. This was fixed one commit later, but the repo as of the 1.21.1 tag still causes this issue.

The current master branch should work. Please download this archive and find the sources in <zip root>/X2WOTCCommunityHighlander/Src/*: https://github.com/X2CommunityCore/X2WOTCCommunityHighlander/archive/master.zip

I will investigate how feasible it is to backport the change to older releases.

@robojumper
Copy link
Member Author

With the stable release of 1.21.1, this should be fixed.

@Iridar Iridar unpinned this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant