Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field 'author' and 'committer' of type 'RepoCommitPage' are wrong #635

Closed
havontuur opened this issue May 4, 2024 · 1 comment
Closed

field 'author' and 'committer' of type 'RepoCommitPage' are wrong #635

havontuur opened this issue May 4, 2024 · 1 comment

Comments

@havontuur
Copy link
Contributor

havontuur commented May 4, 2024 •
edited
Loading

The fields 'author' and 'committer' should be of type 'CommitAuthor' instead of 'GitUserTime'.

pub struct RepoCommitPage {
pub url: Url,
pub author: Option<CommitAuthor>,
pub committer: Option<CommitAuthor>,
pub message: String,
pub comment_count: u64,
pub tree: CommitObject,

#[serde(skip_serializing_if = "Option::is_none")]
pub verification: Option<Verification>,

}
havontuur added a commit to havontuur/octocrab that referenced this issue May 9, 2024
@havontuur
Fix issue XAMPPRocky#635
93e6466
XAMPPRocky pushed a commit that referenced this issue Jun 12, 2024
@havontuur
Fix issue #635 (#637)
f10ab52
@github-actions github-actions bot mentioned this issue Jun 12, 2024
Closed
dmgorsky pushed a commit to dmgorsky/octocrab that referenced this issue Jun 14, 2024
@havontuur @dmgorsky
Fix issue XAMPPRocky#635 (XAMPPRocky#637)
bf4ff4d
XAMPPRocky pushed a commit that referenced this issue Jun 17, 2024
@dmgorsky @akorchyn
@davidsow @havontuur
feat: added /user/blocks functionality (#657)
736ccc1 
* added /user/blocks functionality (is_blocked, block_user, unblock_user, list_blocked)

* Update issues.rs (#634)

* fix(builder): Change add_retry_config signature to match others in OctocrabBuilder (#643)

* Fix issue #635 (#637)

---------

Co-authored-by: Artur Yurii Korchynskyi <42449190+akorchyn@users.noreply.github.com>
Co-authored-by: Kleo Davidson <136495421+davidsow@users.noreply.github.com>
Co-authored-by: Hans Avontuur <hans@adventure-ict.nl>
@maflcko
Copy link
Contributor

maflcko commented Jun 17, 2024

This was fixed and can be closed?

This was referenced Jul 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XAMPPRocky @maflcko @havontuur