Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected navigation when Summary page is not at the end of the form #1292

Open
BenVersion1 opened this issue Sep 27, 2024 · 1 comment
Open

Comments

@BenVersion1
Copy link

Describe the bug
Summary page and confirmation page is skipped in the form when questions are answers. Seems to be issue when summary page not at the end, when there is also conditions added for navigation.

To Reproduce
Steps to reproduce the behavior:

  1. Create form (basic form with no submission - simply used to check eligibility based on answers provided)
  2. 6 questions pages, each with a yes/no question
  3. Summary page
  4. Confirmation page1 (shown if all questions = True)
  5. Confirmation page2 (shown if any question = False)
  6. Next steps shown after Confirmation page2
  7. The pages show individually using preview, but if all questions are answered both summary and confirmations are skipped

Expected behavior
Summary page and confirmation shouldn't be skipped. Should be possible to have a summary page before the end of a form.

Screenshots
image

Repository
designer

Desktop (please complete the following information):

  • OS: [Win 11]
  • Browser [chrome]
  • Version [Version 129.0.6668.60 (Official Build) (64-bit)]

Additional context
Example form I used attached. I'm trying it via https://digital-form-builder-designer.herokuapp.com/app
acs-eligibility-checker-v5.json

@jenbutongit
Copy link
Contributor

jenbutongit commented Sep 27, 2024

Hey @BenVersion1, thanks for reaching out. I quite like this use-case. We have considered using form builder to essentially replace smart answers before 🙂..

It's currently undocumented, but Summary Pages (SummaryPageController) are intended to be the "end" of a form, since this is where all the submissions logic is executed - there's no logic to find and go to the next page. The next page would always be to GOV.UK Pay or to an application confirmation page (the one with the green banner). When the summary page is set to be "skipped", it is just skipping the UI (what's shown to the user), but still executes all of the submission logic.

I've done a recent refactor in #1264. I'll have to have a think, but it might be easier now for me to implement a Summary List component. Otherwise I can create a different page type.

I'll have to get back to you on when I can implement this though. When would you ideally need it by?

If it's easier you can join the slack, or send me an email jen@cautionyourblast.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants