Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey, Choices, Settings should not be case sensistive #572

Open
yanokwa opened this issue Nov 21, 2021 · 1 comment · May be fixed by #746
Open

Survey, Choices, Settings should not be case sensistive #572

yanokwa opened this issue Nov 21, 2021 · 1 comment · May be fixed by #746

Comments

@yanokwa
Copy link
Contributor

yanokwa commented Nov 21, 2021

If you have workbook with Survey or Choices rather than survey and choices, XLSForm reports "Error: The survey sheet is either empty or missing important column headers. I think we these sheet names should be case-insensitive. I thought from #141 addressed it, but using the attached case.xlsx
in pyxform 1.7.0 fails.

@lindsay-stevens
Copy link
Contributor

I can reproduce this with the example file. A quick fix would be to change xls2json_backends.py to:

if sheet.name.lower() not in constants.SUPPORTED_SHEET_NAMES:

The test for this in test_sheet_columns.py is fine. Unfortunately since it is a PyxformXform test it bypasses the raw XLS processing step in xls2json_backends.py where the problem arises. A fix should include an end-to-end test with the sample XLSX file to ensure test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants