Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPC/WS ports to server_info #797

Closed
intelliot opened this issue Aug 1, 2023 · 4 comments
Closed

Add RPC/WS ports to server_info #797

intelliot opened this issue Aug 1, 2023 · 4 comments
Labels
on hold For issues that currently wait on other issues question Further information is requested

Comments

@intelliot
Copy link
Collaborator

XRPLF/rippled#4427
@intelliot intelliot added this to Clio Aug 1, 2023
@intelliot intelliot moved this to Todo in Clio Aug 1, 2023
@godexsoft
Copy link
Collaborator

It looks like this is not very applicable to Clio actually.
We don't have any ports to advertise:

  • The ETL source ports, both gRPC and the ws/wss are already returned in server_info but only for admin users (coming from 127.0.0.1)
  • The port of the Clio server itself is pointless to return in server_info because the client would have had to know it to request the server_info in the first place

cc @intelliot @injaelee

@godexsoft godexsoft added question Further information is requested on hold For issues that currently wait on other issues labels Aug 22, 2023
@intelliot
Copy link
Collaborator Author

Would it be useful to make Clio /crawlable?

https://xrpl.org/peer-crawler.html

This would ensure Clio can (eventually) be a full replacement for rippled "reporting".

@godexsoft
Copy link
Collaborator

I'm not sure if it's applicable @intelliot , it looks like /crawl is for p2p nodes, not for reporting/clio. I don't immediately see a use case for this in Clio but maybe you can explain in more detail what use case you see.

@cindyyan317 cindyyan317 removed this from Clio Nov 20, 2023
@godexsoft
Copy link
Collaborator

Does not look like there is much interest in this. @intelliot i'm going to close this. Feel free to re-open if you disagree and have some more input on this. 👍

@godexsoft godexsoft closed this as not planned Won't fix, can't repro, duplicate, stale Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold For issues that currently wait on other issues question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@intelliot @godexsoft