Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rippled JSON responses compliant with JSON RPC 2.0 specification #214

Closed
ThePiachu opened this issue Nov 21, 2013 · 2 comments
Closed

Comments

@ThePiachu
Copy link

Relevant discussion - https://ripple.com/forum/viewtopic.php?f=2&t=4240&p=23490&sid=ddb111f102ec26ef30c4f35c86614864 .

Looking at the specification - http://json-rpc.org/wiki/specification#a1.2Response - and comparing it to the result I got after sending a random() request to the public rippled server at https://s1.ripple.com:51234 - {'result': {'status': 'success', 'random': '675B6CFA117B2B27A35D9B89600DA1E265539B5C022CD5955547FD8BCA92E17A'}} - I think the response is missing the fields for id and error that should be present (even if null).

Please ensure the JSON responses are compliant with JSON RPC 2.0 specification - this way anyone using standard libraries for JSON RPC would not encounter errors in case the library is pedantic about the data returned.

@vinniefalco
Copy link
Contributor

This seems pretty reasonable, compliance with standards will encourage Ripple adoption. I'm going to mark it as Technical Debt since it is a consequence of an inappropriate earlier design decision.

@vinniefalco
Copy link
Contributor

@HowardHinnant has taken lead on this, and its getting done. This issue is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants