Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line parser issues #2983

Closed
ximinez opened this issue Jun 21, 2019 · 1 comment
Closed

Command line parser issues #2983

ximinez opened this issue Jun 21, 2019 · 1 comment
Labels
Bug Good First Issue Great issue for a new contributor

Comments

@ximinez
Copy link
Collaborator

ximinez commented Jun 21, 2019 •
edited
Loading

  1. Some of the commands which use the parseAccountItems and parseAccountCurrencies functions to interpret the command line options are too restrictive. Specifically account_info and account_currencies are limited to 2 params max, when they should allow three. (account, ledger, "strict").
  2. Not all of the commands which use the above functions are documented as allowing the "strict" parameter. Audit.
  3. A command that returns the rpc error rpcBAD_SYNTAX does not generate any output. Fix fromCommandLine so that it does.
@ximinez ximinez added Good First Issue Great issue for a new contributor Bug labels Jun 21, 2019
ximinez referenced this issue in scottschurr/rippled Jul 1, 2019
@scottschurr
Stabilize RPC error code values:
63d8c08 
The original intent was that RPC error codes were not stable.
But those codes were made available through the API, so some
customers came to depend on the code values.  This change
accepts the current state of affairs.
@movitto movitto mentioned this issue Dec 30, 2019
Closed
@ximinez
Copy link
Collaborator Author

ximinez commented Feb 13, 2020

Addressed by #3196 (which was merged by #3259). Commit message didn't auto-close this issue. Oops.

@ximinez ximinez closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Good First Issue Great issue for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ximinez