Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Stoppable interface #3442

Closed
carlhua opened this issue Jun 4, 2020 · 5 comments
Closed

Refactor Stoppable interface #3442

carlhua opened this issue Jun 4, 2020 · 5 comments
Labels
RIPD Export Exported from legacy JIRA issue tracking

Comments

@carlhua
Copy link
Contributor

carlhua commented Jun 4, 2020

Summary

Currently, the Stoppable interface requires inheritance and constructor parameters, which makes messy declarations of abstract base classes that implement Stoppable. We need to change the way the Stoppable hierarchy is formed to eliminate the need for constructor arguments.

Exported from RIPD-118

@carlhua carlhua added Feature Request Used to indicate requests to add new features RIPD Export Exported from legacy JIRA issue tracking and removed Feature Request Used to indicate requests to add new features labels Jun 4, 2020
@scottschurr
Copy link
Collaborator

@thejohnfreeman, since 78245a0 was merged in 1.7.0-b10, can this issue be closed?

@thejohnfreeman
Copy link
Collaborator

That was a minor cleanup commit. The real refactor is #3741, which is presently awaiting resolution of merge conflicts. I don't mind closing this issue now, or waiting until that PR is merged.

@scottschurr
Copy link
Collaborator

Seems good to wait until #3741 is merged, just in case something unexpected happens.

@scottschurr
Copy link
Collaborator

@thejohnfreeman, I no longer see #3741 as an open pull request. It looks like it was merged in 1.8.0-b3. Are we good to close this issue?

@thejohnfreeman
Copy link
Collaborator

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RIPD Export Exported from legacy JIRA issue tracking
Projects
None yet
Development

No branches or pull requests

3 participants