Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return ledger_index as int, not str, in JSON #3652

Closed
mDuo13 opened this issue Nov 3, 2020 · 2 comments
Closed

Always return ledger_index as int, not str, in JSON #3652

mDuo13 opened this issue Nov 3, 2020 · 2 comments
Labels
API Change Clio Reviewed Feature Request Used to indicate requests to add new features
Milestone

Comments

@mDuo13
Copy link
Collaborator

mDuo13 commented Nov 3, 2020

Summary

This is the "breaking change" follow up to #3533 . The API (v2 or higher) should always return ledger_index fields formatted as the same data type, probably numbers/integers, when serialized to JSON.

Motivation

See #3533 (comment) for some examples of places where ledger_index is returned as an string-integer rather than a proper integer.

@mDuo13 mDuo13 added API Change Feature Request Used to indicate requests to add new features labels Nov 3, 2020
@Bronek
Copy link
Collaborator

Bronek commented Nov 20, 2023

Note, #4820 is planned for API version 3 (not 2)

@intelliot
Copy link
Collaborator

Update: We decided to include #4820 for API version 2. It is merged as of 2.0.0-rc4 (and later).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Core Ledger Dec 6, 2023
@intelliot intelliot moved this from 📋 Backlog to ✅ Merged in Core Ledger Dec 6, 2023
@intelliot intelliot added this to the 2.0.0 milestone Dec 6, 2023
@manojsdoshi manojsdoshi moved this from ✅ Merged to Ready to release in Core Ledger Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change Clio Reviewed Feature Request Used to indicate requests to add new features
Projects
Archived in project
Development

No branches or pull requests

3 participants