Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use network ID instead of URL to identify faucet network #633

Closed
mvadari opened this issue Aug 21, 2023 · 1 comment
Closed

Use network ID instead of URL to identify faucet network #633

mvadari opened this issue Aug 21, 2023 · 1 comment

Comments

@mvadari
Copy link
Collaborator

mvadari commented Aug 21, 2023

The logic determining which faucet to use currently guesses based on the text of the URL of the node the user is connected to. This isn't very robust, as it means if a user is connected to their own node or using an IP address directly, then they need to enter the faucet URL themselves.

We can instead use the network ID of the network the user is connected to, which should always be the same regardless of what node they are using.
@mvadari
Copy link
Collaborator Author

mvadari commented Sep 17, 2024

Closing this as a duplicate of #710

@mvadari mvadari closed this as completed Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvadari