Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constructor.toString().match() returns null - release #1066

Closed
szymonlesisz opened this issue Oct 28, 2019 · 3 comments
Closed

constructor.toString().match() returns null - release #1066

szymonlesisz opened this issue Oct 28, 2019 · 3 comments

Comments

@szymonlesisz
Copy link

Since Chrome@78.0.3904.70 and Firefox@70.0 constructor name returns different values than you expected inside ./src/common/browser-hacks match and throws runtime error.
I saw that you've already fix it in #869
Could you please release this fix to public?

More details:

Chrome:
Screenshot 2019-10-28 at 18 40 42

Firefox:
Screenshot 2019-10-28 at 18 50 17

Funny is that the whole thing is working on localhost but throws below error on production.
However it works before with Chrome@77.0.3865.120 and start failing after Chrome update.

@intelliot
Copy link
Collaborator

So this was a breaking change in Chrome 78?

I'll do a release now.

@intelliot
Copy link
Collaborator

intelliot commented Oct 29, 2019

Fixed in 1.4.0, please confirm and close this issue if it looks good.

@szymonlesisz
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants