-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql.conn.reset_session #7
Comments
@DejeroDaniel Thanks for raising this issue. From the Go Doc about the
It will happen on a second or more calls no matter the call is I not sure we should drop this @seh @fsaintjacques @nvx Any suggestions on this one? 😄 |
I haven't noticed these spans. If this is something the driver is performing involving network activity (or even something that might take a while if interacting with SQLite locally), I'd prefer to see it represented in the traces. If we'd consider filtering this one, I'd prefer that we treat the problem more generally, to avoid adding something to the exported interface for just this particular operation. |
I use both ddtrace and otel, and when I am using gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql and gopkg.in/DataDog/dd-trace-go.v1/contrib/jmoiron/sqlx I don't see these spans at all. They must be filtering it in that library somewhere. Right now I gave the db driver a different service name so I can filter these out in the dashboard, but it is pretty spammy. Even if we think these are important info, I think the |
Definitely agree with that. Also, I think there is no This brings me the idea that we should not instrument a |
Hey, I am using this in my application. Nice work!
An issue is, I am seeing constantly a
sql.conn.reset_session
span. Not sure what it is, but it seems to be happening on each Ping? Very spammy. Should this span be disabled when Ping's are disabled?The text was updated successfully, but these errors were encountered: