-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker: Add multi-arch builds and Loyalsoldier flavor #3589
Conversation
Personal opinion: multi-arch builds are cool, but unless somebody asks for additional builds we should not provide all of them and reduce the list, it's just more CI time spent and more potential failure. Of course I don't know if some of them are useful but I doubt we need all of them. are the container images smaller now? |
Agree. Container VM themselves are the mechanism for cross-arch. I object more complexity for the official docker image. Note there are third party docker build project, you can take a look |
|
@mmmray Now it takes about 9 minutes to build all the images. I am going to limit the multi-arch to amd64, arm64, loong64, and riscv64. |
@mmmray @yuhan6665 After limiting multi-arch to amd64, arm64, loong64, and riscv64, it now takes about 3 minutes. I think this is acceptable, loong64 and riscv64 are becoming more popular. |
i'm ok with merging this, @yuhan6665 what do you think? there is still the fact that it changes default geosite to v2fly, but i think it's ok to be consistent with release tarballs |
I still prefer original version. What do you think @RPRX |
打算第 1001 个 commit 发 v1.8.22, |
我觉得可以 |
@mmmray 试着改一下? |
i can check it later if the feedback isn't addressed by the author, unless you want this for 1.8.22... |
|
Co-authored-by: RPRX <63339210+RPRX@users.noreply.github.com>
Add multi-arch builds (386, amd64, arm, arm64, loong64, mips, mips64, mips64le, mipsle, ppc64, ppc64le, riscv64, s390x):
Replace
alpine
withchainguard/static
, which contains only tzdata and ca-certificates without any ELF binaries, can be built with multi-arch static binaries.https://hub.docker.com/r/chainguard/static
Use official geoip and geosite by default:
Default tags use official geoip and geosite, and this is consistent with the Release version.
Docker builds use official geoip and geosite #3580
Such as:
latest, 1.8.21, main, sha-c07e022
Add Loyalsoldier flavor:
Loyalsoldier flavor tags with suffix
-loyalsoldier
or-l
(short for Loyalsoldier) use the third-party Loyalsoldier geoip and geosite.Such as:
latest-loyalsoldier, latest-l, 1.8.21-loyalsoldier, 1.8.21-l, main-loyalsoldier, main-l, sha-c07e022-loyalsoldier, sha-c07e022-l
Demo repo: https://github.com/mayampi01/Xray-core/pkgs/container/xray-core