-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long format patterns #44
Draft
JPapir
wants to merge
22
commits into
dev
Choose a base branch
from
feature-long-format-patterns
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPapir
force-pushed
the
feature-long-format-patterns
branch
from
November 13, 2024 07:38
722d886
to
712a8f4
Compare
- As we now use long tables, we need to be more memory efficient. We use the category dtype for cells and lexemes. - This required in turn some improvements in how merging and unmerging is handled (otherwise the categories were lost). Hence, I created a Paradigms class and rewrote the unmerging function to make them more efficient.
Ok, this one is next on my list ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch introduces experimental support for long-format patterns (closes #43) in export. It is a major step towards introducing overabundance in downstream scripts.
So far, this has been implemented only for dynamic alignment. It makes the code much simpler in several aspects.
Checklist:
EDIT: removed useless dependency on #37.
EDIT 2: for the doc, the underlying data structure is now the following
Almost everything relies on this single class. A column "applicable" can be added with the list of applicable patterns. Most often, x and y are unoriented, but for entropy, I duplicate the table and x corresponds to the predictor / y to the target.
It is incredibly easy to manipulate with groupby/apply, compared to the previous data structure.
When we store paradigms in non-human readable way, it looks like this:
Notice how we use the form_id to spare some memory by reducing redundant info (lexeme/cell)