Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating type hints #466

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Updating type hints #466

merged 6 commits into from
Aug 22, 2024

Conversation

apchytr
Copy link
Collaborator

@apchytr apchytr commented Aug 19, 2024

Reopening to avoid unwanted commits

Context: The use of Optional and Union should be replaced with | according to PEP standards.

Description of the Change: Optional -> | None, Union -> |, Tuple -> tuple, etc

@apchytr apchytr added the no changelog Pull request does not require a CHANGELOG entry label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.23%. Comparing base (4b2eb81) to head (5718df6).
Report is 1 commits behind head on develop.

Files Patch % Lines
mrmustard/training/parameter_update.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #466   +/-   ##
========================================
  Coverage    89.22%   89.23%           
========================================
  Files          102      102           
  Lines         7201     7206    +5     
========================================
+ Hits          6425     6430    +5     
  Misses         776      776           
Files Coverage Δ
mrmustard/lab/abstract/state.py 92.66% <100.00%> (ø)
mrmustard/lab/abstract/transformation.py 89.53% <100.00%> (ø)
mrmustard/lab/circuit.py 95.08% <100.00%> (-0.08%) ⬇️
mrmustard/lab/detectors.py 79.86% <100.00%> (+0.13%) ⬆️
mrmustard/lab/gates.py 97.25% <100.00%> (+<0.01%) ⬆️
mrmustard/lab/states.py 100.00% <100.00%> (ø)
mrmustard/lab/utils.py 100.00% <100.00%> (ø)
mrmustard/lab_dev/circuit_components.py 98.38% <100.00%> (ø)
...mustard/lab_dev/circuit_components_utils/b_to_q.py 100.00% <ø> (ø)
mrmustard/lab_dev/circuits.py 93.02% <100.00%> (ø)
... and 33 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2eb81...5718df6. Read the comment docs.

Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@apchytr apchytr requested a review from ziofil August 21, 2024 13:23
Copy link
Collaborator

@ziofil ziofil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

@apchytr apchytr merged commit 04b198a into develop Aug 22, 2024
7 checks passed
@apchytr apchytr deleted the typeHints branch August 22, 2024 13:50
@JacobHast JacobHast mentioned this pull request Sep 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants