-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign docs #60
Redesign docs #60
Conversation
The tests are failing on master as well. I added a ticket on that. I think it is a change in the IBM API? The fails complain about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I had some minor comments here as well. I also noticed the line This plugin requires Python version 3.5 and above...
, which probably should be This plugin requires Python version 3.5 or above...
(with an or
instead of and
), but I couldn't comment that line, since it wasn't really part of this PR. It's on line line 61 in README.rst
. 🙂
I noticed that as well. I agree it seems like it could be caused by a change in the IBM API, but I'm not at all familiar with it. I could look into it a bit later, but maybe there's someone else who is more familiar with the API and could solve it quicker. 🙂 |
A couple of months ago, IBM deprecated their original v1 API, for a new v2 API.
|
Co-Authored-By: Theodor <theodor@xanadu.ai>
Co-Authored-By: Theodor <theodor@xanadu.ai>
Co-Authored-By: Theodor <theodor@xanadu.ai>
We decided that I will open an issue, but we wait for further development from the ProjectQ side. |
@josh146 can we merge this besides the failing tests? |
Go for it! |
Description of the Change:
Redesign documentation of the plugin to be consistent with others.
Since this is a larger PR, it is recommended to check the docs in a local build.
The PR also includes a minor change in an import statement, to prevent automodapi from documenting imported classes.