Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the interface of all the gates uniform. #81

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Conversation

nquesada
Copy link
Collaborator

@nquesada nquesada commented Nov 4, 2019

Updates the return of the rotation matrix. Before it returned a 1x1 unitary matrix, now it returns a 2x2 symplectic orthogonal matrix.

@nquesada nquesada requested a review from josh146 November 4, 2019 19:42
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this wasn't the case originally 🤔 Do you think there was a reason behind this, or it was a mistake?

@nquesada
Copy link
Collaborator Author

nquesada commented Nov 4, 2019

Hey Josh --- It was my fault. I was wrapping every called of rotation by an call to interferometer.
But I think it just makes more sense to have all the gates return symplectic matrices.

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          11       11           
  Lines         762      762           
=======================================
  Hits          728      728           
  Misses         34       34
Impacted Files Coverage Δ
thewalrus/symplectic.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43888b...aeb4490. Read the comment docs.

@nquesada nquesada merged commit 207bb34 into master Nov 4, 2019
@nquesada nquesada deleted the update_symplectic branch November 4, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants